netdev - Re: [PATCH v2 0/6] net: fec: Enable Software TSO to improve the tx performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140604.152850.1591854206282161278.davem@davemloft.net>
Date:	Wed, 04 Jun 2014 15:28:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	b38611@...escale.com
Cc:	netdev@...r.kernel.org, shawn.guo@...aro.org, R49496@...escale.com,
	ezequiel.garcia@...e-electrons.com, bhutchings@...arflare.com,
	stephen@...workplumber.org, b20596@...escale.com,
	David.Laight@...LAB.COM, eric.dumazet@...il.com
Subject: Re: [PATCH v2 0/6] net: fec: Enable Software TSO to improve the tx
 performance

I think you need to start taking David Laight's feedback more seriously.

He's right, it makes no sense at all the increase the number of RX
descriptors for the sake of a send side feature like TSO.

If you have a another reason to increase the RX descriptor count, do
it as a separate change and with an appropriate commit log message
explaining WHY you are doing this.

I'm not applying this patch series until you start taking the feedback
you are receiving to heart.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html