netdev - Re: [PATCH] sh_eth: fix SH7619/771x support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140603.190229.1248289002649714904.davem@davemloft.net>
Date:	Tue, 03 Jun 2014 19:02:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yoshihiro.shimoda.uh@...esas.com
Cc:	sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: fix SH7619/771x support

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Date: Wed, 4 Jun 2014 09:34:56 +0900

> (2014/06/04 4:42), Sergei Shtylyov wrote:
>> Commit 4a55530f38e4 (net: sh_eth: modify the definitions of register) managed
>> to leave out the E-DMAC register entries in sh_eth_offset_fast_sh3_sh2[], thus
>> totally breaking SH7619/771x support.  Add the missing entries using  the data
>> from before that commit.
>> 
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
 ...
> I checked sh7710 and sh7619 datasheet, but they don't have RPADIR register.
> Since I would like to check a datasheet you looked into, would you tell me about this?

I think what Sergei simply did is take what was used for register offsets
before the mentioned commits.

The RPADIR register write is guarded by "mdp->cd->rpadir" being non-zero,
so his change is very safe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html