netdev - Re: [PATCH v2 0/7] net: Support checksum in UDP tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx8hBvZ6dH1BEZaASQH2bh9=w-TMpF2_NZVRYOAy6cR-Fg@mail.gmail.com>
Date:	Wed, 4 Jun 2014 16:11:37 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 0/7] net: Support checksum in UDP tunnels

On Wed, Jun 4, 2014 at 3:28 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Sun, Jun 1, 2014 at 9:00 PM, Tom Herbert <therbert@...gle.com> wrote:
>> This patch series adds support for using checksums in UDP tunnels. With
>> this it is possible that two or more checksums may be set within the
>> same packet and we would like to do that efficiently.
>
> Do you also plan to implement double checksum offload in the absence
> of TSO? I know it is functionally correct now but it's not offloaded.

We'd need HW support for that (like NETIF_F_HW_CSUM2). I think there
is some justification in light of tunneling protocols over UDP that
carry sensitive data, like virtual network ID, and don't otherwise
have any provision at L3 to detect data corruption (e.g. vxlan).

To implement, I think this is just another pair of checksum offsets
(csum_start, csum_offset) (CHECKSUM_PARTIAL2?) that a driver would
implement. Both csum_start and csum_offset could also be stored in 8
bits (right shifted to give values up to 510) if there are concerns
about space in TX descriptors.

Are any vendors interested in this functionality?

Thanks,
Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html