netdev - Re: [linux-nics] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1401925517.19767.175.camel@jtkirshe-mobl>
Date:	Wed, 04 Jun 2014 16:45:17 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Don@...tope.jf.intel.com, e1000-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Linux@...tope.jf.intel.com,
	NICS <linux.nics@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	netdev@...r.kernel.org
Subject: Re: [linux-nics] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c:
 Cleaning up missing null-terminate after strncpy call

On Wed, 2014-06-04 at 23:29 +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
> 
> This was partly found using a static code analysis program called
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist
> <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

NAK, I won't be picking this patch up based on Mark's and Joe's
feedback.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)