netdev - Re: [Patch net-next] net: remove some useless list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140603.172451.2132501802596004067.davem@davemloft.net>
Date:	Tue, 03 Jun 2014 17:24:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [Patch net-next] net: remove some useless list_del()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue,  3 Jun 2014 17:11:55 -0700

> "list_kill" is allocated on stack and it's a list head,
> it is pointless to call list_del(&kill_list) especially
> after unregister_netdevice_many().
> 
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Do not edit what you do not understand:

commit ceaaec98ad99859ac90ac6863ad0a6cd075d8e0e                                                                         
Author: Eric Dumazet <eric.dumazet@...il.com>                                                                           
Date:   Thu Feb 17 22:59:19 2011 +0000                                                                                  
                                                                                                                        
    net: deinit automatic LIST_HEAD                                                                                     
                                                                                                                        
    commit 9b5e383c11b08784 (net: Introduce                                                                             
    unregister_netdevice_many()) left an active LIST_HEAD() in                                                          
    rollback_registered(), with possible memory corruption.                                                             
                                                                                                                        
    Even if device is freed without touching its unreg_list (and therefore                                              
    touching the previous memory location holding LISTE_HEAD(single), better                                            
    close the bug for good, since its really subtle.                                                                    
                                                                                                                        
    (Same fix for default_device_exit_batch() for completeness)                                                         
                                                                                                                        
    Reported-by: Michal Hocko <mhocko@...e.cz>                                                                          
    Tested-by: Michal Hocko <mhocko@...e.cz>                                                                            
    Reported-by: Eric W. Biderman <ebiderman@...ssion.com>                                                              
    Tested-by: Eric W. Biderman <ebiderman@...ssion.com>                                                                
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>                                                       
    Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>                                                                
    CC: Ingo Molnar <mingo@...e.hu>                                                                                     
    CC: Octavian Purdila <opurdila@...acom.com>                                                                         
    CC: stable <stable@...nel.org> [.33+]                                                                               
    Signed-off-by: David S. Miller <davem@...emloft.net>                                                                
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html