netdev - RE: [PATCH v2 4/6] net: fec: Increase buffer descriptor entry number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17256FBF@AcuExch.aculab.com>
Date:	Wed, 4 Jun 2014 09:26:52 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Fugang Duan' <b38611@...escale.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"R49496@...escale.com" <R49496@...escale.com>,
	"ezequiel.garcia@...e-electrons.com" 
	<ezequiel.garcia@...e-electrons.com>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"b20596@...escale.com" <b20596@...escale.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: RE: [PATCH v2 4/6] net: fec: Increase buffer descriptor entry number

From: Fugang Duan
> In order to support SG, software TSO, let's increase BD entry number.
> 
> CC: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
> CC: Eric Dumazet <eric.dumazet@...il.com>
> CC: David Laight <David.Laight@...LAB.COM>
> Signed-off-by: Fugang Duan <B38611@...escale.com>
> ---
>  drivers/net/ethernet/freescale/fec.h      |    6 +++---
>  drivers/net/ethernet/freescale/fec_main.c |   21 ++++++++++++---------
>  2 files changed, 15 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
> index 3b8d6d1..798ad88 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -240,14 +240,14 @@ struct bufdesc_ex {
>   * the skbuffer directly.
>   */
> 
> -#define FEC_ENET_RX_PAGES	8
> +#define FEC_ENET_RX_PAGES	128
>  #define FEC_ENET_RX_FRSIZE	2048
>  #define FEC_ENET_RX_FRPPG	(PAGE_SIZE / FEC_ENET_RX_FRSIZE)
>  #define RX_RING_SIZE		(FEC_ENET_RX_FRPPG * FEC_ENET_RX_PAGES)
> ...

You are changing the number of rx descriptors as well.
This isn't mentioned in the description.

And, as I said before, basing this on PAGE_SIZE cannot be right.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html