netdev - Re: [PATCH v5 net-next] MPLS: Use mpls_features to activate software MPLS GSO segmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140604101336.GE17695@casper.infradead.org>
Date:	Wed, 4 Jun 2014 11:13:36 +0100
From:	Thomas Graf <tgraf@...g.ch>
To:	Simon Horman <horms@...ge.net.au>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Jesse Gross <jesse@...ira.com>,
	YAMAMOTO Takashi <yamamoto@...inux.co.jp>, dev@...nvswitch.org
Subject: Re: [PATCH v5 net-next] MPLS: Use mpls_features to activate software
 MPLS GSO segmentation

On 06/04/14 at 08:53am, Simon Horman wrote:
> If an MPLS packet requires segmentation then use mpls_features
> to determine if the software implementation should be used.
> 
> As no driver advertises MPLS GSO segmentation this will always be
> the case.
> 
> I had not noticed that this was necessary before as software MPLS GSO
> segmentation was already being used in my test environment. I believe that
> the reason for that is the skbs in question always had fragments and the
> driver I used does not advertise NETIF_F_FRAGLIST (which seems to be the
> case for most drivers). Thus software segmentation was activated by
> skb_gso_ok().
> 
> This introduces the overhead of an extra call to skb_network_protocol()
> in the case where where CONFIG_NET_MPLS_GSO is set and
> skb->ip_summed == CHECKSUM_NONE.
> 
> Thanks to Jesse Gross for prompting me to investigate this.
> 
> Signed-off-by: Simon Horman <horms@...ge.net.au>
> Acked-by: YAMAMOTO Takashi <yamamoto@...inux.co.jp>

LGTM

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html