netdev - Re: [PATCH] sh_eth: fix SH7619/771x support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <538F12F1.5000701@cogentembedded.com>
Date:	Wed, 04 Jun 2014 16:37:05 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>
Subject: Re: [PATCH] sh_eth: fix SH7619/771x support

Hello.

On 06/04/2014 04:34 AM, Yoshihiro Shimoda wrote:

>> Commit 4a55530f38e4 (net: sh_eth: modify the definitions of register) managed
>> to leave out the E-DMAC register entries in sh_eth_offset_fast_sh3_sh2[], thus
>> totally breaking SH7619/771x support.  Add the missing entries using  the data
>> from before that commit.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

>> ---
>> The patch is against Dave Miller's 'net.git' repo.
>> Although there have been no complaints during 3+ years of this being broken, I
>> think it's probably worth queuing the patch for the stable trees...

>>   drivers/net/ethernet/renesas/sh_eth.c |   21 +++++++++++++++++++++
>>   1 file changed, 21 insertions(+)

>> Index: net/drivers/net/ethernet/renesas/sh_eth.c
>> ===================================================================
>> --- net.orig/drivers/net/ethernet/renesas/sh_eth.c
>> +++ net/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -307,6 +307,27 @@ static const u16 sh_eth_offset_fast_sh4[
>>   };
>>
>>   static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = {
>> +	[EDMR]		= 0x0000,
>> +	[EDTRR]		= 0x0004,
>> +	[EDRRR]		= 0x0008,
>> +	[TDLAR]		= 0x000c,
>> +	[RDLAR]		= 0x0010,
>> +	[EESR]		= 0x0014,
>> +	[EESIPR]	= 0x0018,
>> +	[TRSCER]	= 0x001c,
>> +	[RMFCR]		= 0x0020,
>> +	[TFTR]		= 0x0024,
>> +	[FDR]		= 0x0028,
>> +	[RMCR]		= 0x002c,
>> +	[EDOCR]		= 0x0030,
>> +	[FCFTR]		= 0x0034,
>> +	[RPADIR]	= 0x0038,

> I checked sh7710 and sh7619 datasheet, but they don't have RPADIR register.
> Since I would like to check a datasheet you looked into, would you tell me about this?

    As I wrote in the changelog, I used the driver source. I don't have access 
to SH7619/771x datasheets.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html