netdev - Re: [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53906A23.5040006@lab.ntt.co.jp>
Date:	Thu, 05 Jun 2014 22:01:23 +0900
From:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	"David S . Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>,
	David Laight <David.Laight@...LAB.COM>,
	Vlad Yasevich <vyasevic@...hat.com>, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org
Subject: Re: [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

(2014/06/05 21:30), Michael S. Tsirkin wrote:
> On Thu, Jun 05, 2014 at 08:53:32PM +0900, Toshiaki Makita wrote:
>> br_manage_promisc() incorrectly expects br_auto_port() to return only 0
>> or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK.
>>
>> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
>> ---
>>  net/bridge/br_if.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
>> index a08d2b8..3eca3fd 100644
>> --- a/net/bridge/br_if.c
>> +++ b/net/bridge/br_if.c
>> @@ -153,7 +153,8 @@ void br_manage_promisc(struct net_bridge *br)
>>  			 * This lets us disable promiscuous mode and write
>>  			 * this config to hw.
>>  			 */
>> -			if (br->auto_cnt <= br_auto_port(p))
>> +			if (br->auto_cnt == 0 ||
>> +			    (br->auto_cnt == 1 && br_auto_port(p)))
>>  				br_port_clear_promisc(p);
>>  			else
>>  				br_port_set_promisc(p);
> 
> It's all a nasty side-effect of using macros IMHO.
> 
> How about we just make these inline functions returning bool?
> 
> The bugfix will fall out naturally.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> 
> Warning: untested.
> 
> 
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 53d6e32..5818dd2 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -200,8 +200,15 @@ struct net_bridge_port
>  #endif
>  };
>  
> -#define br_auto_port(p) ((p)->flags & BR_AUTO_MASK)
> -#define br_promisc_port(p) ((p)->flags & BR_PROMISC)
> +static inline bool br_auto_port(struct net_bridge_port *p)
> +{
> +	return p->flags & BR_AUTO_MASK;
> +}
> +
> +static inline bool br_promisc_port(struct net_bridge_port *p)
> +{
> +	return p->flags & BR_PROMISC;
> +}
>  
>  #define br_port_exists(dev) (dev->priv_flags & IFF_BRIDGE_PORT)

This also looks good.

IMHO, the caller side should not assume these macros (or inline
functions) return boolean value.  There exists similar macro such as
br_port_exists() that doesn't return boolean.

Ohterwise, we should change all macros into boolean functions, but it
might affect performance a little if such a macro is used in fast path?
(I'm worried about the cost of casting non-zero values into 1.)

Thanks,
Toshiaki Makita
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html