netdev - RE: [PATCH net-next] bridge: Fix incorrect judgment of promisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17257DCF@AcuExch.aculab.com>
Date:	Thu, 5 Jun 2014 13:47:30 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Toshiaki Makita' <makita.toshiaki@....ntt.co.jp>,
	"David S . Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>
CC:	Vlad Yasevich <vyasevic@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bridge@...ts.linux-foundation.org" 
	<bridge@...ts.linux-foundation.org>
Subject: RE: [PATCH net-next] bridge: Fix incorrect judgment of promisc

From: Toshiaki Makita 
> > A quick truth table:
> > 	auto_cnt	auto_port	set/clear
> > 		0		0	clear
> > 		0		1	clear
> > 		1		0	set
> > 		1		1	clear
> > 		2+		0/1	clear
> 
> The last line should be set.

I've clearly not drunk enough coffee today...

I suspect the 0-1 line is impossible.
Since the check is probably for 'any other ports in 'auto' mode'.
So:
	if (auto_cnt - auto_port > 0)
(which is much the same as the original) is a good descriptive test.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html