netdev - Re: [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcbyD7xKHCeE0S28+bjdja82EGWr9TXute7uQjsefsu8NQ@mail.gmail.com>
Date:	Thu, 5 Jun 2014 11:00:13 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Alexander Stein <alexander.stein@...tec-electronic.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Daniel Krueger <daniel.krueger@...tec-electronic.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe

2014-06-05 1:53 GMT-07:00 Alexander Stein
<alexander.stein@...tec-electronic.com>:
> From: Daniel Krueger <daniel.krueger@...tec-electronic.com>
>
> It is also neat to show the actual offending MAC address instead of just
> rejecting it

Most drivers do use a random Ethernet MAC address instead of bailing
out, which might be a more sensible option.

>
> Signed-off-by: Daniel Krueger <daniel.krueger@...tec-electronic.com>
> Signed-off-by: Alexander Stein <alexander.stein@...tec-electronic.com>
> ---
>
> Changes in v2:
> * Use just a single line
>
>  drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> index 73e6683..cf3101c 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> @@ -2672,8 +2672,7 @@ static int pch_gbe_probe(struct pci_dev *pdev,
>                  * prevent the interface from being brought up until a valid MAC
>                  * is set.
>                  */
> -               dev_err(&pdev->dev, "Invalid MAC address, "
> -                                   "interface disabled.\n");
> +               dev_err(&pdev->dev, "Invalid MAC address %pM - interface disabled.\n", adapter->hw.mac.addr);
>         }
>         setup_timer(&adapter->watchdog_timer, pch_gbe_watchdog,
>                     (unsigned long)adapter);
> --
> 1.8.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html