netdev - Re: Bug 75571

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Mi-mBXWSytEtJhqEfjYQyrd9zae5GndYy3qmK=+_mk_g@mail.gmail.com>
Date:	Thu, 5 Jun 2014 12:18:06 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Alex <d77190@...l.ru>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: Bug 75571

On Wed, Jun 4, 2014 at 10:22 PM, Alex <d77190@...l.ru> wrote:
> В Ср, 04/06/2014 в 17:27 -0700, Cong Wang пишет:
>
>> Thanks for testing!
>>
>> Thinking a bit more, the question is why
>> skb_push(skb->dev->hard_header_len) is not correct here? It looks
>> like we don't calculate tunnel->dev->hard_header_len correctly. But
>> ipip_tunnel_bind_dev() should do the right thing less your setup is not
>> correct, in that case your ipip tunnel should not receive any packet.
>> We should be safe.
>>
>> Which is the interface routing to 192.168.18.17 on your system? Which
>> driver does it use?
>
> Its a stock e1000e from kernel with no special options. No jumbo frames,
> etc.
>
> lspci says:
> Ethernet controller: Intel Corporation 82572EI Gigabit Ethernet
> Controller (Copper) (rev 06)
>
> IPIP tunnel runs on top of this interface.
>

Hmm, e1000e should init dev->hard_header_len to ETH_LEN, which is 14.
Plus IPv4 header len (20), it should be about 34. I don't understand why
the ipip tunnel's hard_header_len is 148 in your case. It is only possible when
there is no underlying interface, that is, LL_MAX_HEADER + sizeof(struct iphdr).

What do `ip -d link show` and `ip route show` say?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html