netdev - Re: [PATCH] gianfar: Call netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140605.150416.1615019571569772686.davem@davemloft.net>
Date:	Thu, 05 Jun 2014 15:04:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	claudiu.manoil@...escale.com, netdev@...r.kernel.org,
	fabio.estevam@...escale.com
Subject: Re: [PATCH] gianfar: Call netif_carrier_off() prior to registration

From: Fabio Estevam <festevam@...il.com>
Date: Tue,  3 Jun 2014 19:55:38 -0300

> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Quoting David Miller:
> "At the moment you call register_netdev() the device is visible, notifications
> are sent to userspace, and userland tools can try to bring the interface up
> and see the incorrect link state, before you do the netif_carrier_off().
> 
> Said another way, between the register_netdev() and netif_carrier_off() call,
> userspace can see the device in an inconsistent state."
> 
> So call netif_carrier_off() prior to register_netdev().
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html