netdev - Re: [PATCH V2 net-next] LISP: Locator/Identifier Separation Protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7MU6mcQjvqzHT5qSsPzxdbPC=pSh3MbNF2yOUNJocKiJg@mail.gmail.com>
Date:	Thu, 5 Jun 2014 15:12:08 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Christopher White <chris@...icalelegance.com>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	"Vina Ermagan (vermagan)" <vermagan@...co.com>,
	"Lorand Jakab -X (lojakab - M SQUARED CONSULTING INC. at Cisco)" 
	<lojakab@...co.com>
Subject: Re: [PATCH V2 net-next] LISP: Locator/Identifier Separation Protocol

On Thu, Jun 5, 2014 at 2:14 PM, Christopher White
<chris@...icalelegance.com> wrote:
> +void lisp_sock_release(struct lisp_sock *s)
> +{
> +       struct sock *sk = s->sock->sk;
> +       struct net *net = sock_net(sk);
> +       struct lisp_net *ln = net_generic(net, lisp_net_id);
> +
> +       if (!atomic_dec_and_test(&s->refcnt))
> +               return;
> +       spin_lock(&ln->sock_lock);
> +       hlist_del_rcu(&s->hlist);
> +       rcu_assign_sk_user_data(s->sock->sk, NULL);
> +       spin_unlock(&ln->sock_lock);
> +       queue_work(lisp_wq, &s->del_work);
> +}
> +EXPORT_SYMBOL_GPL(lisp_sock_release);

Why do you export this symbol?


> +
> +static int create_v4_sock(struct net *net, __be16 port, struct socket **psock,
> +                         u32 flags)
> +{


It looks like this function is very similar to the one in vxlan tunnel,
it would be better to unify and move it to net/core/sock.c.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html