netdev - Re: [PATCH 1/3] net: phylib: add adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jun 2014 22:11:29 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Daniel Mack <zonque@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>, marek.belisko@...il.com,
	Matus Ujhelyi <ujhelyi.m@...il.com>
Subject: Re: [PATCH 1/3] net: phylib: add adjust_state callback to phy device

2014-06-04 2:00 GMT-07:00 Daniel Mack <zonque@...il.com>:
> Allow phy drivers to take action when the core does its link adjustment.
> No change for drivers that do not implement this callback.

This sounds potentially dangerous if misused, PHY drivers would
basically be allowed to do arbitrary link state changes based on their
custom needs. I really need to review your workaround here to better
understand whether we can come up with a solution that allows for less
liberty in PHY drivers.

Thanks

>
> Signed-off-by: Daniel Mack <zonque@...il.com>
> ---
>  drivers/net/phy/phy.c | 3 +++
>  include/linux/phy.h   | 3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 3bc079a..f9c5577 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -720,6 +720,9 @@ void phy_state_machine(struct work_struct *work)
>
>         mutex_lock(&phydev->lock);
>
> +       if (phydev->drv->adjust_state)
> +               phydev->drv->adjust_state(phydev);
> +
>         switch (phydev->state) {
>         case PHY_DOWN:
>         case PHY_STARTING:
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 51d15f6..27cbdf4 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -529,6 +529,9 @@ struct phy_driver {
>         /* See set_wol, but for checking whether Wake on LAN is enabled. */
>         void (*get_wol)(struct phy_device *dev, struct ethtool_wolinfo *wol);
>
> +       /* Called when the PHY core adjusts the link of a PHY device */
> +       void (*adjust_state)(struct phy_device *dev);
> +
>         struct device_driver driver;
>  };
>  #define to_phy_driver(d) container_of(d, struct phy_driver, driver)
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html