netdev - Re: [PATCH V2 net-next] LISP: Locator/Identifier Separation Protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402010800.3645.279.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 05 Jun 2014 16:26:40 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Christopher White <chris@...icalelegance.com>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	"Vina Ermagan (vermagan)" <vermagan@...co.com>,
	"Lorand Jakab -X (lojakab - M SQUARED CONSULTING INC. at Cisco)" 
	<lojakab@...co.com>
Subject: Re: [PATCH V2 net-next] LISP: Locator/Identifier Separation Protocol

On Thu, 2014-06-05 at 14:14 -0700, Christopher White wrote:
> This is a static tunnel implementation of LISP as described in RFC 6830:
>   http://tools.ietf.org/html/rfc6830
> 

> +static void lisp_sock_put(struct sk_buff *skb)
> +{
> +	sock_put(skb->sk);
> +}
> +
> +/* On transmit, associate with the tunnel socket */
> +static void lisp_set_owner(struct sock *sk, struct sk_buff *skb)
> +{
> +	skb_orphan(skb);
> +	sock_hold(sk);
> +	skb->sk = sk;
> +	skb->destructor = lisp_sock_put;
> +}
> +

Please do not do that. 

Read commit 8f646c922d55047ecd6c65ada49ead88ed0db61e
("vxlan: keep original skb ownership")
for details.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html