netdev - Re: [PATCH net-next] net: ipconfig: allow IP-Config over DSA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140605.000132.501712848318656492.davem@davemloft.net>
Date:	Thu, 05 Jun 2014 00:01:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, buytenh@...tstofly.org, jiri@...nulli.us
Subject: Re: [PATCH net-next] net: ipconfig: allow IP-Config over DSA
 devices

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 30 May 2014 11:08:45 -0700

> Let me know your thoughts. If you feel like something like:
> netdev_is_upper_dev() or something like that is better.

I'm not happy with this change for several reasons.

First, I don't like the idea that ipconfig works for some stacked
devices and not for others.  I'd rather that we simply accept that
direct devices are the only thing supported.

Secondly, the logic in that ipconfig loop is so confusing.  I can't
even figure out what that dsa pointer test is trying to really
accomplish in the second hunk of your patch.

I'd like to defer this for now, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html