netdev - RE: [PATCH v2 0/6] net: fec: Enable Software TSO to improve the tx performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1699266c40be4b1cb5aa212390c97dbe@BLUPR03MB373.namprd03.prod.outlook.com>
Date:	Thu, 5 Jun 2014 08:11:42 +0000
From:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>,
	"ezequiel.garcia@...e-electrons.com" 
	<ezequiel.garcia@...e-electrons.com>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"David.Laight@...LAB.COM" <David.Laight@...LAB.COM>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: RE: [PATCH v2 0/6] net: fec: Enable Software TSO to improve the tx
 performance

Hi, David,

From: David Miller <davem@...emloft.net> Data: Thursday, June 05, 2014 6:29 AM
> To: Duan Fugang-B38611
> Cc: netdev@...r.kernel.org; shawn.guo@...aro.org; Estevam Fabio-R49496;
> ezequiel.garcia@...e-electrons.com; bhutchings@...arflare.com;
> stephen@...workplumber.org; Li Frank-B20596; David.Laight@...LAB.COM;
> eric.dumazet@...il.com
> Subject: Re: [PATCH v2 0/6] net: fec: Enable Software TSO to improve the tx
> performance
> 
> 
> I think you need to start taking David Laight's feedback more seriously.
> 
> He's right, it makes no sense at all the increase the number of RX
> descriptors for the sake of a send side feature like TSO.
> 
> If you have a another reason to increase the RX descriptor count, do it as
> a separate change and with an appropriate commit log message explaining WHY
> you are doing this.
> 
> I'm not applying this patch series until you start taking the feedback you
> are receiving to heart.

Considering with David Laight's suggestion by previous mail, I decide to remove the RX descriptors number change for the patch set.
After the patch set, I have another patch serial for new feature support like interrupt coalescing that request
RX descriptors number is enough big.  I will generate one separate patch to increase RX BDs entry.

I will send the V3 for the change.

Thanks,
Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html