netdev - [PATCH v2 6/6] pch_gbe: remove shutdown and restart of interface after PHY settings change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1401958387-8154-6-git-send-email-alexander.stein@systec-electronic.com>
Date:	Thu,  5 Jun 2014 10:53:07 +0200
From:	Alexander Stein <alexander.stein@...tec-electronic.com>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	Daniel Krueger <daniel.krueger@...tec-electronic.com>,
	netdev@...r.kernel.org,
	Alexander Stein <alexander.stein@...tec-electronic.com>
Subject: [PATCH v2 6/6] pch_gbe: remove shutdown and restart of interface after PHY settings change

From: Daniel Krueger <daniel.krueger@...tec-electronic.com>

This is not necessary. mii_ethtool_sset retriggers the autonegociation if
necessary automatically.

Signed-off-by: Daniel Krueger <daniel.krueger@...tec-electronic.com>
Signed-off-by: Alexander Stein <alexander.stein@...tec-electronic.com>
---
 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
index fbfac98..2284042 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
@@ -128,13 +128,6 @@ static int pch_gbe_set_settings(struct net_device *netdev,
 	hw->phy.autoneg_advertised = ecmd->advertising;
 	hw->mac.autoneg = ecmd->autoneg;
 
-	/* reset the link */
-	if (netif_running(adapter->netdev)) {
-		pch_gbe_down(adapter);
-		ret = pch_gbe_up(adapter);
-	} else {
-		pch_gbe_reset(adapter);
-	}
 	return ret;
 }
 
-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html