netdev - RE: [net-next 04/13] i40evf: make messages less dire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2014 17:23:52 +0000
From:	"Williams, Mitch A" <mitch.a.williams@...el.com>
To:	Joe Perches <joe@...ches.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net-next 04/13] i40evf: make messages less dire



> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Friday, June 06, 2014 5:19 AM
> To: Kirsher, Jeffrey T
> Cc: davem@...emloft.net; Williams, Mitch A; netdev@...r.kernel.org;
> gospo@...hat.com; sassmann@...hat.com
> Subject: Re: [net-next 04/13] i40evf: make messages less dire
> 
> On Fri, 2014-06-06 at 02:04 -0700, Jeff Kirsher wrote:
> > Depending on the timing of what the PF driver is doing, it make take a
> > few tries before the VF driver is able to communicate with the PF driver
> > on init or reset recovery. In order to prevent confusion, make the most
> > common messages less scary by lowering them to a less terrifying log
> > level and indicate that the driver will retry.
> []
> > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> []
> > @@ -1963,7 +1963,7 @@ static void i40evf_init_task(struct work_struct
> *work)
> >  		}
> >  		err = i40evf_check_reset_complete(hw);
> >  		if (err) {
> > -			dev_err(&pdev->dev, "Device is still in reset (%d)\n",
> > +			dev_info(&pdev->dev, "Device is still in reset (%d),
> retrying\n",
> >  				err);
> >  			goto err;
> >  		}
> > @@ -1996,7 +1996,7 @@ static void i40evf_init_task(struct work_struct
> *work)
> >  		/* aq msg sent, awaiting reply */
> >  		err = i40evf_verify_api_ver(adapter);
> >  		if (err) {
> > -			dev_err(&pdev->dev, "Unable to verify API version (%d)\n",
> > +			dev_info(&pdev->dev, "Unable to verify API version (%d),
> retrying\n",
> >  				err);
> >  			goto err;
> >  		}
> 
> trivia:
> 
> It'd be nicer to reindent the multi-line statements.
> 
> CHECK: Alignment should match open parenthesis
> #73: FILE: drivers/net/ethernet/intel/i40evf/i40evf_main.c:1967:
> +			dev_info(&pdev->dev, "Device is still in reset (%d),
> retrying\n",
>  				err);
> 
> CHECK: Alignment should match open parenthesis
> #82: FILE: drivers/net/ethernet/intel/i40evf/i40evf_main.c:2000:
> +			dev_info(&pdev->dev, "Unable to verify API version (%d),
> retrying\n",
>  				err);
> 

Thanks, Joe. Thought I had those correct, but obviously I'm one character off here.

Now that checkpatch has been switch to pedantic mode, I think what I'll do is (once I get everything else working) run the entire driver through checkpatch and send out a single patch that fixes all of the formatting niggles.

-Mitch
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html