netdev - Re: [PATCH] isdn: mISDN: dsp_cmx.c: Cleaning up a define that is no longer available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 06 Jun 2014 16:28:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rickard_strandqvist@...ctrumdigital.se
Cc:	isdn@...ux-pingi.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: mISDN: dsp_cmx.c: Cleaning up a define that is
 no longer available

From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Date: Sat,  7 Jun 2014 01:25:30 +0200

> Removes an ifdef that is no longer available,
> and that would cause a compile error if it was activated.
> 
> This was partly found using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

This indentation looks wrong, and if you scan up you'll see why.

A different set of CPP guards create the openning curly brace(s):

	/* PROCESS DATA (two members) */
#ifdef CMX_CONF_DEBUG
	if (0) {
#else
		if (members == 2) {
#endif

This is crazy, and deleting only the DSP_NEVER_DEFINED part makes it
even more confusing because less sophisticated code analysis tools and
editing mode will think that the braces are unbalanced now.

I'm not applying this, it makes things worse not better, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html