[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 06 Jun 2014 01:24:24 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: thierry.reding@...il.com
Cc: zhangfei.gao@...aro.org, arnd@...db.de, f.fainelli@...il.com,
sergei.shtylyov@...entembedded.com, mark.rutland@....com,
David.Laight@...LAB.COM, eric.dumazet@...il.com,
haifeng.yan@...aro.org, jchxue@...il.com,
linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/2] net: hisilicon: add hix5hd2 mac driver
From: Thierry Reding <thierry.reding@...il.com>
Date: Fri, 6 Jun 2014 10:19:18 +0200
> On Tue, Jun 03, 2014 at 01:49:37PM +0800, Zhangfei Gao wrote:
> [...]
>> diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
>> new file mode 100644
>> index 0000000..e942173
>> --- /dev/null
>> +++ b/drivers/net/ethernet/hisilicon/Kconfig
>> @@ -0,0 +1,27 @@
>> +#
>> +# HISILICON device configuration
>> +#
>> +
>> +config NET_VENDOR_HISILICON
>> + bool "Hisilicon devices"
>> + default y
>
> Can this default please be dropped? It's annoying because it will cause
> this driver to be built for *every* ARM kernel by default, whether or
> not that hardware is available on a given board.
People mistakedly say this every time, this config option is not for
the driver, it's a VENDOR guard.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists