netdev - Re: [net-next 04/15] i40evf: remove unnecessary log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402248222.6328.8.camel@joe-AO725>
Date:	Sun, 08 Jun 2014 10:23:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Mitch Williams <mitch.a.williams@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 04/15] i40evf: remove unnecessary log messages

On Sun, 2014-06-08 at 07:33 -0700, Jeff Kirsher wrote:
> From: Mitch Williams <mitch.a.williams@...el.com>

A slightly associated trivial note:

One day it'd be nicer to use the same "if (!foo)"
test style everywhere.

> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
[]
> @@ -662,12 +661,9 @@ i40evf_vlan_filter *i40evf_add_vlan(struct i40evf_adapter *adapter, u16 vlan)
[]
>  		f = kzalloc(sizeof(*f), GFP_ATOMIC);
> -		if (NULL == f) {
> -			dev_info(&adapter->pdev->dev,
> -				 "%s: no memory for new VLAN filter\n",
> -				 __func__);
> +		if (NULL == f)
>  			return NULL;
> -		}
> +

[]

> @@ -1610,11 +1603,9 @@ static void i40evf_adminq_task(struct work_struct *work)
>  
>  	event.msg_size = I40EVF_MAX_AQ_BUF_SIZE;
>  	event.msg_buf = kzalloc(event.msg_size, GFP_KERNEL);
> -	if (!event.msg_buf) {
> -		dev_info(&adapter->pdev->dev, "%s: no memory for ARQ clean\n",
> -				 __func__);
> +	if (!event.msg_buf)
>  		return;
> -	}
> +


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html