netdev - Re: [PATCH net-next] net: force a list_del() in unregister_netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140608.141531.1369298233316729957.davem@davemloft.net>
Date:	Sun, 08 Jun 2014 14:15:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: force a list_del() in
 unregister_netdevice_many()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 06 Jun 2014 06:44:03 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> unregister_netdevice_many() API is error prone and we had too
> many bugs because of dangling LIST_HEAD on stacks.
> 
> See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")
> 
> In fact, instead of making sure no caller leaves an active list_head,
> just force a list_del() in the callee. No one seems to need to access
> the list after unregister_netdevice_many()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> I based this patch on net-next, but it seems to close existing bugs,
> so its probably a stable candidate.

It applied cleanly to net so I applied it there and will queue up for -stable,
thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html