netdev - Re: [PATCH 1/2] net: sh_eth: Fix receive packet "exceeded" condition in sh_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53959359.1060407@cogentembedded.com>
Date:	Mon, 09 Jun 2014 14:58:33 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	SH-Linux <linux-sh@...r.kernel.org>
Subject: Re: [PATCH 1/2] net: sh_eth: Fix receive packet "exceeded" condition
 in sh_eth_rx()

Hello.

On 09-06-2014 14:39, Yoshihiro Shimoda wrote:

> This patch fixes the packet "exceeded" condition in sh_eth_rx() when
> RACT in an RX descriptor is not set and the "quota" is 0.
> Otherwise, kernel panic happens because the "&n->poll_list" is deleted
> twice in sh_eth_poll() which calls napi_complete() and net_rx_action().

> Signed-off-by: Kouei Abe <kouei.abe.cp@...esas.com>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> ---
>   drivers/net/ethernet/renesas/sh_eth.c |    8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)

> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 08ed9a3..ad0b5bd 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
> @@ -1508,7 +1506,7 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status, int *quota)
>   		sh_eth_write(ndev, EDRRR_R, EDRRR);
>   	}
>
> -	return exceeded;
> +	return (*quota <= 0);

    Parens not needed here.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html