netdev - Re: [PATCH iproute2] bridge: Make filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140609124032.4b3fdea9@nehalam.linuxnetplumber.net>
Date:	Mon, 9 Jun 2014 12:40:32 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Andreas Henriksson <andreas@...al.se>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] bridge: Make filter_index match in signedness

On Wed,  4 Jun 2014 19:40:37 +0200
Andreas Henriksson <andreas@...al.se> wrote:

> From the original report at http://bugs.debian.org/749155
> Michael Tautschnig wrote:
> 
> During a rebuild [...]. Please note that we use our research
> compiler tool-chain (using tools from the cbmc package), which permits extended
> reporting on type inconsistencies at link time.
> 
> [...]
> gcc   bridge.o fdb.o monitor.o link.o mdb.o vlan.o ../lib/libnetlink.a ../lib/libutil.a  ../lib/libnetlink.a ../lib/libutil.a -o bridge
> file link.c line 18: error: conflicting types for variable "filter_index"
> old definition in module fdb file fdb.c line 29
> signed int
> new definition in module link file link.c line 18
> unsigned int
> <builtin>: recipe for target 'bridge' failed
> make[3]: *** [bridge] Error 64
> make[3]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-iproute2/iproute2-3.14.0/bridge'
> Makefile:45: recipe for target 'all' failed
> 
> While practical constraints may limit the value of filter_index to remain within
> the bounds of a positive signed int, there is certainly no such guarantee here.
> Also, a plain majority vote suggests that this really just a wrong declaration
> in link.c as several declarations of filter_index as signed int exist.
> 
> [...]
> 
> My followup on this was:
> 
> I think the majority is wrong.
> 
> filter_index is assigned exclusively from if_nametoindex or ll_name_to_index
> which both return unsigned int.
> 
> Changing it to unsigned everywhere seems better.
> 
> This has been minimally tested by using the bridge tool
> to add vids and showing available vids on different devices.
> 
> Reported-by: Michael Tautschnig <mt@...ian.org>
> Signed-off-by: Andreas Henriksson <andreas@...al.se>

Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html