netdev - Re: [net-next 01/13] i40e: add checks for AQ error status bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402348710.3142.29.camel@joe-AO725>
Date:	Mon, 09 Jun 2014 14:18:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	davem@...emloft.net, Shannon Nelson <shannon.nelson@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 01/13] i40e: add checks for AQ error status bits

On Mon, 2014-06-09 at 14:10 -0700, Jeff Kirsher wrote:
> Well, as Shannon noted in the patch description:
> "If the Firmware sets these bits, it will trigger an AdminQ
> interrupt to get the driver's attention to process the ARQ, which will
> likely be enough to clear the actual issue."

Yeah, I quoted that too.

> To me that means the log messages should not be filling up with these
> types of messages and if they do occur, it should be transient and
> resolve itself.  So does that warrant dev_dbg? 

No idea.  That's up to you.  They're your messages.

I guess it depends on what you expect your users to
do when these are emitted.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html