netdev - Re: [Xen-devel] [PATCH] net: xen-netback: include linux/vmalloc.h again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402390356.29980.3.camel@kazak.uk.xensource.com>
Date:	Tue, 10 Jun 2014 09:52:36 +0100
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	Arnd Bergmann <arnd@...db.de>,
	Josh Boyer <jwboyer@...oraproject.org>,
	<netdev@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	"Andrew J. Bennieston" <andrew.bennieston@...rix.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [Xen-devel] [PATCH] net: xen-netback: include linux/vmalloc.h
 again

On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote:
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> > commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> > queue struct") added a use of vzalloc/vfree to interface.c, but
> > removed the #include <linux/vmalloc.h> statement at the same time,
> > which causes this build error:
> > 
> > drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> > drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >   vfree(vif->queues);
> >   ^
> > cc1: some warnings being treated as errors
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Cc: Wei Liu <wei.liu2@...rix.com>
> > Cc: Andrew J. Bennieston <andrew.bennieston@...rix.com>
> 
> Acked-by: Wei Liu <wei.liu2@...rix.com>
> 
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?

Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-)

Ian.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html