netdev - Re: [PATCH net-next 2/2] mac802154: don't deliver packets to devices that are down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402413961.3645.432.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 10 Jun 2014 08:26:01 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>
Cc:	netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net,
	davem@...emloft.net
Subject: Re: [PATCH net-next 2/2] mac802154: don't deliver packets to
 devices that are down

On Tue, 2014-06-10 at 17:08 +0200, Phoebe Buckheister wrote:
> Only one WPAN devices can be active at any given time, so only deliver
> packets to that one interface that is actually up.
> 
> Signed-off-by: Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>
> ---
>  net/mac802154/wpan.c |   12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/net/mac802154/wpan.c b/net/mac802154/wpan.c
> index c8cfd54..1ba648e 100644
> --- a/net/mac802154/wpan.c
> +++ b/net/mac802154/wpan.c
> @@ -567,7 +567,6 @@ static int mac802154_parse_frame_start(struct sk_buff *skb,
>  void mac802154_wpans_rx(struct mac802154_priv *priv, struct sk_buff *skb)
>  {
>  	int ret;
> -	struct sk_buff *sskb;
>  	struct mac802154_sub_if_data *sdata;
>  	struct ieee802154_hdr hdr;
>  
> @@ -579,12 +578,15 @@ void mac802154_wpans_rx(struct mac802154_priv *priv, struct sk_buff *skb)
>  
>  	rcu_read_lock();
>  	list_for_each_entry_rcu(sdata, &priv->slaves, list) {
> -		if (sdata->type != IEEE802154_DEV_WPAN)
> +		if (sdata->type != IEEE802154_DEV_WPAN ||
> +		    !netif_running(sdata->dev))
>  			continue;
>  
> -		sskb = skb_clone(skb, GFP_ATOMIC);
> -		if (sskb)
> -			mac802154_subif_frame(sdata, sskb, &hdr);
> +		skb = skb_clone(skb, GFP_ATOMIC);
> +		if (skb)
> +			mac802154_subif_frame(sdata, skb, &hdr);
> +
> +		break;
>  	}
>  	rcu_read_unlock();
>  }

If this is really the case, do not clone the skb, and fix
mac802154_subif_rx().

(mac802154_wpans_rx() would always consume the skb)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html