netdev - Re: [patch iproute2 1/3] iproute2: arpd: use ll_addr_a2n and ll_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140610160940.GD2991@minipsycho.orion>
Date:	Tue, 10 Jun 2014 18:09:40 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org, mschmidt@...hat.com
Subject: Re: [patch iproute2 1/3] iproute2: arpd: use ll_addr_a2n and
 ll_addr_n2a

Tue, Jun 10, 2014 at 05:50:25PM CEST, jiri@...nulli.us wrote:
>Mon, Jun 09, 2014 at 09:47:22PM CEST, stephen@...workplumber.org wrote:
>>On Sat, 17 May 2014 10:50:31 +0200
>>Jiri Pirko <jiri@...nulli.us> wrote:
>>
>>> Sat, May 17, 2014 at 05:58:16AM CEST, stephen@...workplumber.org wrote:
>>> >On Thu, 15 May 2014 18:50:51 +0200
>>> >Jiri Pirko <jiri@...nulli.us> wrote:
>>> >
>>> >> Thu, May 15, 2014 at 05:43:42PM CEST, stephen@...workplumber.org wrote:
>>> >> >On Thu, 15 May 2014 15:10:20 +0200
>>> >> >Jiri Pirko <jiri@...nulli.us> wrote:
>>> >> >
>>> >> >> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>>> >> >> ---
>>> >> >>  misc/arpd.c | 6 +++---
>>> >> >>  1 file changed, 3 insertions(+), 3 deletions(-)
>>> >> >> 
>>> >> >
>>> >> >Why not use more standard ether_ntoa ?
>>> >> 
>>> >> Because the rest of the code uses ll_addr_n2a. There is no user of
>>> >> ether_ntoa in iproute2.
>>> >
>>> >arpd is more of a standalone program.
>>> 
>>> I know but it is a part of the package (git tree). The other instances
>>> use ll_addr_n2a. I'm ok with using ether_ntoa, I just wanted to follow
>>> what is already there.
>>> 
>>> I can change it and post v2 it you want. I can also change other instances
>>> of usage ll_addr_n2a to ether_ntoa.
>>> 
>>> 
>>
>>This is fine, just went ahead and merged this version.
>
>
>Stephen, looks like you missed the last (3/3) patch from this set. I
>can't see it in the iproute2 git.

Oh, you already applied that before. That confused me because "iproute2:
ipa: show port id" actuall adds code which calls hexstring_n2a :)

Anyway, all good now. Sorry for the fuzz.

>
>Thanks
>
>Jiri
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html