netdev - [PATCH net-next] ndisc: use netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140611113109.4c104592@nehalam.linuxnetplumber.net>
Date:	Wed, 11 Jun 2014 11:31:09 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: [PATCH net-next] ndisc: use netdev_alloc_skb

IPv6 neighbor discovery should use netdev_alloc_skb which adds
extra space for headroom. The old code would allocate packet w/o any
additional headroom and force drivers to reallocate and copy the
packet in some cases.

Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>


--- a/net/ipv6/ndisc.c	2014-06-03 08:06:35.549942475 -0700
+++ b/net/ipv6/ndisc.c	2014-06-11 08:54:31.729764741 -0700
@@ -375,7 +375,7 @@ static struct sk_buff *ndisc_alloc_skb(s
 	struct sock *sk = dev_net(dev)->ipv6.ndisc_sk;
 	struct sk_buff *skb;
 
-	skb = alloc_skb(hlen + sizeof(struct ipv6hdr) + len + tlen, GFP_ATOMIC);
+	skb = netdev_alloc_skb(dev, hlen + sizeof(struct ipv6hdr) + len + tlen);
 	if (!skb) {
 		ND_PRINTK(0, err, "ndisc: %s failed to allocate an skb\n",
 			  __func__);
@@ -383,7 +383,6 @@ static struct sk_buff *ndisc_alloc_skb(s
 	}
 
 	skb->protocol = htons(ETH_P_IPV6);
-	skb->dev = dev;
 
 	skb_reserve(skb, hlen + sizeof(struct ipv6hdr));
 	skb_reset_transport_header(skb);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html