netdev - RE: [PATCH net 1/4] bnx2x: Fix link for KR with swapped polarity lane

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2014 18:40:35 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	netdev <netdev@...r.kernel.org>,
	Yaniv Rosner <Yaniv.Rosner@...gic.com>
CC:	David Miller <davem@...emloft.net>,
	Ariel Elior <Ariel.Elior@...gic.com>
Subject: RE: [PATCH net 1/4] bnx2x: Fix link for KR with swapped polarity
 lane

>> +                             MDIO_WC_REG_RX0_PCI_CTRL + (0x10 * lane), &val);

>    () around * not needed. You could also replace it by (lane << 4).

Hi,

bnx2x_link.c is full of format inconsistencies, as well as many cases of
unnecessary parenthesis.
It might be reasonable to send a semantic script to `net-next' in order
to fix all those issues, but I'm not sure we should re-spin this series
only because of such `common' inconsistencies.

Dave - whichever you prefer; If you want me to re-spin it, I will.

Cheers,
Yuval

________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html