netdev - Re: [PATCH net-next v4] net: add __pskb_copy_fclone and pskb_copy_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140611.151426.1918105360214405187.davem@davemloft.net>
Date:	Wed, 11 Jun 2014 15:14:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	octavian.purdila@...el.com
Cc:	netdev@...r.kernel.org, christoph.paasch@...ouvain.be,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	mareklindner@...mailbox.ch, sw@...onwunderlich.de,
	antonio@...hcoding.com, marcel@...tmann.org, gustavo@...ovan.org,
	johan.hedberg@...il.com, arvid.brodin@...en.se, kaber@...sh.net,
	pablo@...filter.org, kadlec@...ckhole.kfki.hu,
	lauro.venancio@...nbossa.org, aloisio.almeida@...nbossa.org,
	sameo@...ux.intel.com, jon.maloy@...csson.com,
	allan.stephens@...driver.com, andrew.hendry@...il.com,
	edumazet@...gle.com
Subject: Re: [PATCH net-next v4] net: add __pskb_copy_fclone and
 pskb_copy_for_clone

From: Octavian Purdila <octavian.purdila@...el.com>
Date: Thu, 12 Jun 2014 00:41:27 +0300

> @@ -2235,9 +2241,17 @@ static inline dma_addr_t skb_frag_dma_map(struct device *dev,
>  static inline struct sk_buff *pskb_copy(struct sk_buff *skb,
>  					gfp_t gfp_mask)
>  {
> -	return __pskb_copy(skb, skb_headroom(skb), gfp_mask);
> +	return __pskb_copy_fclone(skb, skb_headroom(skb), gfp_mask, false);
>  }

This hunk is unnecessary, the whole point of keeping __pskb_copy()'s signature
the same is to avoid these kinds of edits.

Please get rid of this hunk and I'll apply this, thank you!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html