netdev - Re: [PATCH 1/2] ip_tunnel: GSO: Add check for nested encap.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140610.222120.1648194413371340927.davem@davemloft.net>
Date:	Tue, 10 Jun 2014 22:21:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] ip_tunnel: GSO: Add check for nested encap.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Sun, 25 May 2014 04:39:32 -0700

> +	if (skb_is_gso(skb)) {
> +		if (unlikely(skb->encapsulation)) {
> +			/* Current networking GSO stack can handle
> +			 * only one level of encapsulation. */
> +			err = -ENOSYS;
> +			goto error;
> +		}

This is not the correct way to format a comment in the kernel networking
code, the proper way is:

	/* Like
	 * this.
	 */

Also, you need to provide a cover posting for a patch series explaining
at a high level what this patch series is accomplishing.  Also you need
to explicitly indicate what tree this set of changes is targetting.

Given the amount of changes you've contributed in the past, I am at a
loss as to why I have to explain all of this to someone with your level
of experience.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html