netdev - Re: [PATCH net-next v5] net: add __pskb_copy_fclone and pskb_copy_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140611.153823.1721612284882638761.davem@davemloft.net>
Date:	Wed, 11 Jun 2014 15:38:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	octavian.purdila@...el.com
Cc:	netdev@...r.kernel.org, christoph.paasch@...ouvain.be,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	mareklindner@...mailbox.ch, sw@...onwunderlich.de,
	antonio@...hcoding.com, marcel@...tmann.org, gustavo@...ovan.org,
	johan.hedberg@...il.com, arvid.brodin@...en.se, kaber@...sh.net,
	pablo@...filter.org, kadlec@...ckhole.kfki.hu,
	lauro.venancio@...nbossa.org, aloisio.almeida@...nbossa.org,
	sameo@...ux.intel.com, jon.maloy@...csson.com,
	allan.stephens@...driver.com, andrew.hendry@...il.com,
	edumazet@...gle.com
Subject: Re: [PATCH net-next v5] net: add __pskb_copy_fclone and
 pskb_copy_for_clone

From: Octavian Purdila <octavian.purdila@...el.com>
Date: Thu, 12 Jun 2014 01:36:26 +0300

> There are several instances where a pskb_copy or __pskb_copy is
> immediately followed by an skb_clone.
> 
> Add a couple of new functions to allow the copy skb to be allocated
> from the fclone cache and thus speed up subsequent skb_clone calls.
 ...
> Reviewed-by: Christoph Paasch <christoph.paasch@...ouvain.be>
> Signed-off-by: Octavian Purdila <octavian.purdila@...el.com>
> ---
> 
> Changes since v4:
>  * Oops, as Dave noticed, there is no need to rewrite pskb_copy()
> 
> Changes since v3:
>  * As suggested by David and Dave add new functions to keep the
>    existing signatures unchanged and avoid unnecessary changes  
> 
> Changes since v2:
>  * As suggested by Dave, use a bool instead of directly exposing the
>    internal allocation flags
> 
> Changes since v1:
>  * add new parameter to pskb_copy as well, as suggested by Christoph

Applied to net-next, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html