netdev - Re: [PATCH v2 0/4] net: Checksum offload changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140611.154635.2203844517927313680.davem@davemloft.net>
Date:	Wed, 11 Jun 2014 15:46:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 0/4] net: Checksum offload changes - Part IV

From: Tom Herbert <therbert@...gle.com>
Date: Tue, 10 Jun 2014 18:54:03 -0700 (PDT)

> I am working on overhauling RX checksum offload. Goals of this effort
> are:
> 
> - Specify what exactly it means when driver returns CHECKSUM_UNNECESSARY
> - Preserve CHECKSUM_COMPLETE through encapsulation layers
> - Don't do skb_checksum more than once per packet
> - Unify GRO and non-GRO csum verification as much as possible
> - Unify the checksum functions (checksum_init)
> - Simply code
> 
> What is in this fourth patch set:
> 
> - Preserve CHECKSUM_COMPLETE instead of changing it to
>   CHECKSUM_UNNECESSARY. This allows correct reuse in validating multiple
>   csums in a packet.
> - When SW needs to compute the packet checksum, save it as
>   CHECKSUM_COMPLETE. Also mark that checksum was compute by SW.
> - Add skb_gro_postpull_rcsum to udp and vxlan to make GRO work with
>   CHECKSUM_COMPLETE.
> 
> v2: Removed patch setting skb_encapsulation when validating checksum
>     in tcp_gro_receive
> 
> Please review carefully and test if possible, mucking with basic
> checksum functions is always a little precarious :-)

Series applied, thanks Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html