netdev - Re: [PATCH 1/1] net_sched: drr: warn when qdisc is not work conserving

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2014 15:59:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH 1/1] net_sched: drr: warn when qdisc is not work
 conserving

From: Florian Westphal <fw@...len.de>
Date: Wed, 11 Jun 2014 20:35:18 +0200

> The DRR scheduler requires that items on the active list are work
> conserving, i.e. do not hold on to skbs for throttling purposes, etc.
> Attaching e.g. tbf renders DRR useless because all other classes on the
> active list are delayed as well.
> 
> So, warn users that this configuration won't work as expected; we
> already do this in couple of other qdiscs, see e.g.
> 
> commit b00355db3f88d96810a60011a30cfb2c3469409d
> ('pkt_sched: sch_hfsc: sch_htb: Add non-work-conserving warning handler')
> 
> The 'const' change is needed to avoid compiler warning ("discards 'const'
> qualifier from pointer target type").
> 
> tested with:
> drr_hier() {
>         parent=$1
>         classes=$2
>         for i in  $(seq 1 $classes); do
>                 classid=$parent$(printf %x $i)
>                 tc class add dev eth0 parent $parent classid $classid drr
> 		tc qdisc add dev eth0 parent $classid tbf rate 64kbit burst 256kbit limit 64kbit
>         done
> }
> tc qdisc add dev eth0 root handle 1: drr
> drr_hier 1: 32
> tc filter add dev eth0 protocol all pref 1 parent 1: handle 1 flow hash keys dst perturb 1 divisor 32
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html