netdev - Re: [PATCH v2 net-next] farsync: Fix confusion about DMA address and buffer offset types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140611.004553.333169592369134204.davem@davemloft.net>
Date:	Wed, 11 Jun 2014 00:45:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	netdev@...r.kernel.org, kevin.curtis@...site.co.uk
Subject: Re: [PATCH v2 net-next] farsync: Fix confusion about DMA address
 and buffer offset types

From: Ben Hutchings <ben@...adent.org.uk>
Date: Sun, 08 Jun 2014 23:49:34 +0100

> Use dma_addr_t for DMA address parameters and u32 for shared memory
> offset parameters.
> 
> Do not assume that dma_addr_t is the same as unsigned long; it will
> not be in PAE configurations.  Truncate DMA addresses to 32 bits when
> printing them.  This is OK because the DMA mask for this device is
> 32-bit (per default).
> 
> Also rename the DMA address parameters from 'skb' to 'dma'.
> 
> Compile-tested only.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html