netdev - Re: [PATCH] net/core: Add VF link state control policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53980CC6.1080303@mellanox.com>
Date:	Wed, 11 Jun 2014 11:01:10 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Doug Ledford <dledford@...hat.com>, <netdev@...r.kernel.org>
CC:	Rony Efraim <ronye@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net/core: Add VF link state control policy

On 10/06/2014 22:59, Doug Ledford wrote:
> Commit 1d8faf48c7 added VF link state control to the netlink VF nested
> structure, but failed to add a proper entry for the new structure into
> the VF policy table.  Add the missing entry so the table and the actual
> data copied into the netlink nested struct are in sync.
>
> Signed-off-by: Doug Ledford <dledford@...hat.com>
> ---
>   net/core/rtnetlink.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 2d8d8fcfa06..cdccf028171 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1208,6 +1208,8 @@ static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
>   				    .len = sizeof(struct ifla_vf_tx_rate) },
>   	[IFLA_VF_SPOOFCHK]	= { .type = NLA_BINARY,
>   				    .len = sizeof(struct ifla_vf_spoofchk) },
> +	[IFLA_VF_LINK_STATE]	= { .type = NLA_BINARY,
> +				    .len = sizeof(struct ifla_vf_link_state) },
>   };

nice catch, thanks. Note that currently this table isn't in use, so 
fixing here would  actually serve to avoid future bugs, but this is of 
course OK too.

Rony and Or.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html