netdev - Re: [PATCH 2/2] openvswitch: Enable tunnel GSO for OVS bridge.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZJ0c21oxPs=B3rb+v5M+rE37+C1T-78fR73V-fUcOpJ6Q@mail.gmail.com>
Date:	Wed, 11 Jun 2014 12:26:18 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Alon Harel <alonha@...lanox.com>
Subject: Re: [PATCH 2/2] openvswitch: Enable tunnel GSO for OVS bridge.

On Sun, May 25, 2014 at 2:39 PM, Pravin B Shelar <pshelar@...ira.com> wrote:
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>

Hi Pravin,

Can you please provide a non-empty change log for this patch... I
understand the patch
addresses some openvswitch use case where offloads are currently
non-coming into play and
you want to support that, right?


> +++ b/include/linux/netdev_features.h
> @@ -152,6 +152,10 @@ enum {
>  #define NETIF_F_ALL_FCOE       (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \
>                                  NETIF_F_FSO)
>
> +#define NETIF_F_ALL_ENCAP_GSO   (NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM | \
> +                                NETIF_F_GSO_IPIP | NETIF_F_GSO_SIT |     \
> +                                NETIF_F_GSO_UDP_TUNNEL | NETIF_F_GSO_MPLS)

AFAIK OVS supports only VXLAN and GRE tunneling -- wouldn't it be
enough to add here only
NETIF_F_GSO_GRE and NETIF_F_GSO_UDP_TUNNEL?

> +
>  /*
>   * If one device supports one of these features, then enable them
>   * for all in netdev_increment_features.
> diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
> index 789af92..b971610 100644
> --- a/net/openvswitch/vport-internal_dev.c
> +++ b/net/openvswitch/vport-internal_dev.c
> @@ -134,7 +134,8 @@ static void do_setup(struct net_device *netdev)
>         netdev->tx_queue_len = 0;
>
>         netdev->features = NETIF_F_LLTX | NETIF_F_SG | NETIF_F_FRAGLIST |
> -                          NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_GSO_SOFTWARE;
> +                          NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_GSO_SOFTWARE |
> +                          NETIF_F_ALL_ENCAP_GSO;
>
>         netdev->vlan_features = netdev->features;
>         netdev->features |= NETIF_F_HW_VLAN_CTAG_TX;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html