netdev - Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140612090745.GV11959@zion.uk.xensource.com>
Date:	Thu, 12 Jun 2014 10:07:45 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	David Miller <davem@...emloft.net>
CC:	<wei.liu2@...rix.com>, <arnd@...db.de>, <netdev@...r.kernel.org>,
	<andrew.bennieston@...rix.com>, <xen-devel@...ts.xenproject.org>,
	<jwboyer@...oraproject.org>
Subject: Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

On Wed, Jun 11, 2014 at 03:19:01PM -0700, David Miller wrote:
> From: Wei Liu <wei.liu2@...rix.com>
> Date: Tue, 10 Jun 2014 09:44:54 +0100
> 
> > On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> >> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> >> queue struct") added a use of vzalloc/vfree to interface.c, but
> >> removed the #include <linux/vmalloc.h> statement at the same time,
> >> which causes this build error:
> >> 
> >> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> >> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >>   vfree(vif->queues);
> >>   ^
> >> cc1: some warnings being treated as errors
> >> 
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >> Cc: Wei Liu <wei.liu2@...rix.com>
> >> Cc: Andrew J. Bennieston <andrew.bennieston@...rix.com>
> > 
> > Acked-by: Wei Liu <wei.liu2@...rix.com>
> > 
> > This didn't happen to me when I built it on x86 though. Just curious,
> > did you build it on othet platform, say, ARM?
> 
> ARM and PowerPC will both show this problem.
> 
> The issue is that x86 get's linux/vmalloc.h implicitly through one of
> it's asm/ headers, thus you'll never hit the issue if you only build
> test on that arch.

Good to know. I shall keep an eye on this in the future.

Thanks
Wei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html