netdev - Re: [PATCH] tcp: fixing TLP's FIN recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402583577.3645.477.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 12 Jun 2014 07:32:57 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Weiping Pan <panweiping3@...il.com>
Cc:	Nandita Dukkipati <nanditad@...gle.com>,
	Per Hurtig <per.hurtig@....se>,
	Netdev <netdev@...r.kernel.org>,
	Anna Brunström <anna.brunstrom@....se>,
	mohammad.rajiullah@....se, Neal Cardwell <ncardwell@...gle.com>,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH] tcp: fixing TLP's FIN recovery

On Thu, 2014-06-12 at 22:21 +0800, Weiping Pan wrote:
> When we queue an out of order pure FIN packet, we do not check whether 
> it has data or not.
> tcp_rcv_established
> -->tcp_data_queue
> ---->tcp_data_queue_ofo
> 
> Then the pure FIN packet can generate SACK, which will trigger fast 
> recovery or early retransmit on the sender.
> >
> > If you have verified that a pure FIN does indeed trigger recovery, can
> > you tell me what part of the code makes that happen?
> Here is the patch I use, I think the original if statement is useless, 
> so I delete it.

Yes, this is exactly what we agreed, and what we tested as well here at
Google.

Per, can you submit an updated official version of the patch ?

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html