netdev - Re: [PATCH 1/2] ip_tunnel: GSO: Add check for nested encap.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+oAR0O_iYRSK2hCqio3Rte99Shz4qCSh3pqgJjSVUmP7w@mail.gmail.com>
Date:	Thu, 12 Jun 2014 08:35:45 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2] ip_tunnel: GSO: Add check for nested encap.

On Tue, Jun 10, 2014 at 10:21 PM, David Miller <davem@...emloft.net> wrote:
> From: Pravin B Shelar <pshelar@...ira.com>
> Date: Sun, 25 May 2014 04:39:32 -0700
>
>> +     if (skb_is_gso(skb)) {
>> +             if (unlikely(skb->encapsulation)) {
>> +                     /* Current networking GSO stack can handle
>> +                      * only one level of encapsulation. */
>> +                     err = -ENOSYS;
>> +                     goto error;
>> +             }
>
> This is not the correct way to format a comment in the kernel networking
> code, the proper way is:
>
>         /* Like
>          * this.
>          */
>
> Also, you need to provide a cover posting for a patch series explaining
> at a high level what this patch series is accomplishing.  Also you need
> to explicitly indicate what tree this set of changes is targetting.
>

Sorry, I will send updated patch. Lately I been working mostly on
ovs-dev so I missed few conventions.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html