netdev - Re: Linux 3.4.92 breaks forwarding with netfilter enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140612172516.GA2556@bender.morinfr.org>
Date:	Thu, 12 Jun 2014 19:25:16 +0200
From:	Guillaume Morin <guillaume@...infr.org>
To:	gregkh@...uxfoundation.org, Florian Westphal <fw@...len.de>
Cc:	Jiri Slaby <jslaby@...e.cz>, stable@...r.kernel.org,
	ML netdev <netdev@...r.kernel.org>
Subject: Re: Linux 3.4.92 breaks forwarding with netfilter enabled

On 11 Jun 10:10, Florian Westphal wrote:
>
> Jiri Slaby <jslaby@...e.cz> wrote:
> > > Gergely, please either revert
> > > 
> > > commit bd91cb56f951a7b0da8c3098ea9cd56854ece66c
> > > Author: Florian Westphal <fw@...len.de>
> > > net: ipv4: ip_forward: fix inverted local_df test
> > > [ Upstream commit ca6c5d4ad216d5942ae544bbf02503041bd802aa ]
> > > 
> > > Or, alternatively, also apply upstream commit 895162b1101b3ea5db08ca6822ae9672717efec0
> > > Author: Florian Westphal <fw@...len.de>
> > > Date:   Fri May 2 15:32:16 2014 +0200
> > > netfilter: ipv4: defrag: set local_df flag on defragmented skb
> > > 
> > > on top of your 3.4.92 kernel.
> > > 
> > > (The latter might be a better option since it will also fix the
> > >  long-standing issue where netfilter sends bogus frag-needed message
> > >  under very rare circumstances).
> > 
> > I believe, the same holds for 3.12, right? (I have just applied "defrag:
> > set local_df flag on defragmented skb".)
> 
> Yes, its true for all -stable kernels (except new 3.15).
> 
> Thanks for taking care of this.

Greg, could you apply this one to 3.4,3.10,3.14 as well please?

Or do have concerns about it?

Thanks,

Guillaume.

-- 
Guillaume Morin <guillaume@...infr.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html