lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 13 Jun 2014 13:28:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bvanassche@....org
Cc:	vyasevic@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Silence a W=1 compiler warning

From: Bart Van Assche <bvanassche@....org>
Date: Fri, 13 Jun 2014 16:12:49 +0200

> Avoid that the following compiler warning is reported when building
> with W=1:
> 
> include/linux/netdevice.h: In function 'netif_addr_lock_nested':
> include/linux/netdevice.h:2865:6: warning: variable 'subclass' set but not used [-Wunused-but-set-variable]
>   int subclass = SINGLE_DEPTH_NESTING;
>       ^
> 
> This patch does not change any functionality.
> 
> Signed-off-by: Bart Van Assche <bvanassche@....org>

This has already been discussed.

The spin_lock_nested() with your configuration should be adjusted to
mark the argument as used.

There is nothing wrong with this code, it should not warn, it's
simply the spin locking macros that need to be fixed.

I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists