netdev - Re: [Patch net] vxlan: use dev->needed_headroom instead of dev->hard_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140613.152926.1695048625021986920.davem@davemloft.net>
Date:	Fri, 13 Jun 2014 15:29:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	pshelar@...ira.com, cwang@...pensource.com
Subject: Re: [Patch net] vxlan: use dev->needed_headroom instead of
 dev->hard_header_len

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu, 12 Jun 2014 11:53:10 -0700

> From: Cong Wang <cwang@...pensource.com>
> 
> When we mirror packets from a vxlan tunnel to other device,
> the mirror device should see the same packets (that is, without
> outer header). Because vxlan tunnel sets dev->hard_header_len,
> tcf_mirred() resets mac header back to outer mac, the mirror device
> actually sees packets with outer headers
> 
> Vxlan tunnel should set dev->needed_headroom instead of
> dev->hard_header_len, like what other ip tunnels do. This fixes
> the above problem.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: stephen hemminger <stephen@...workplumber.org>
> Cc: Pravin B Shelar <pshelar@...ira.com>
> Signed-off-by: Cong Wang <cwang@...pensource.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

This looks good, and as you say consistent with how other IP tunnel
types are handled.

Applied, and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html