lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Jun 2014 11:28:53 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: vyasevic@...hat.com, davem@...emloft.net, stephen@...workplumber.org CC: netdev@...r.kernel.org, sfeldma@...ulusnetworks.com, john.r.fastabend@...el.com, roopa@...ulusnetworks.com Subject: Re: [net-next PATCH 2/2] bridge: netlink dump interface at par with brctl On 06/10/14 09:25, Vlad Yasevich wrote: > > I gave it some thought and I think something like the following > pseudo-code would work. > > dump_dev_fdbs(dev, filter) > { > if (dev->dumper) > dev->ndo_dumper(dev, filter); > else > default_dumper(dev, filter); > } > > for_each_netdev() { > if (bridge_filter) { > if (dev->index != bridge_filter) > skip; > > dump_dev_fdbs(dev, port_filter); > } else { > if (port_filter) { > if (bridge_port && > dev->index != port_filter) > skip; > > } > > if (bridge_port) { > br_dev = get_bridge(); > dump_dev_fdbs(br_dev, port_filter); > } > > dump_dev_fdbs(dev, port_filter); > } > } > > > What do you think? Too bad i missed the net-next submission. I am not sure what you suggest above will improve upon readability, but i will take another run at it when Dave opens up. I know reading the patch was hard - the code was not as bad. We'll see. cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists