netdev - RE: SCTP seems to lose its socket state.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1725CDEF@AcuExch.aculab.com>
Date:	Mon, 16 Jun 2014 08:40:30 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Vlad Yasevich' <vyasevich@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: SCTP seems to lose its socket state.

From: Vlad Yasevich
...
> Yeah.  We do end up queuing a bit more commands. Need to see if
> all them are necessary..

I wonder why commands get queued, rather than just actioned with
an immediate function call?
I suspect it is steeped into the history of the code.

All of the commands have to be (and are) actioned before any other
packets (etc) can be processed otherwise there will be massive
problems with the socket/association state.

Simply calling the functions is likely change the order of the
actions - which might break things.
OTOH direct calls would make it much easier to audit the sequences.

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html