netdev - Re: SCTP seems to lose its socket state.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140617112830.GC8539@hmsreliant.think-freely.org>
Date:	Tue, 17 Jun 2014 07:28:30 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	'Vlad Yasevich' <vyasevich@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: SCTP seems to lose its socket state.

On Mon, Jun 16, 2014 at 08:40:30AM +0000, David Laight wrote:
> From: Vlad Yasevich
> ...
> > Yeah.  We do end up queuing a bit more commands. Need to see if
> > all them are necessary..
> 
> I wonder why commands get queued, rather than just actioned with
> an immediate function call?
> I suspect it is steeped into the history of the code.
> 
> All of the commands have to be (and are) actioned before any other
> packets (etc) can be processed otherwise there will be massive
> problems with the socket/association state.
> 
> Simply calling the functions is likely change the order of the
> actions - which might break things.
> OTOH direct calls would make it much easier to audit the sequences.
> 
> 	David
> 
That last bit is the point. The stack was written to presume that the state of a
connection would be consistent while the state processing function executed, so
commands were queued to be handled as side effects after that was complete.
There should be no reason you can't call the command functions directly, as long as
you audit each state machine function to ensure it doesn't rely on any state
that the command alters after the call.

Neil

> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html