netdev - Re: Device Tree Binding for Marvell DSA on P1023RDB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcY-khbCM3rB5qsNSq2Y+ekeH-4RyW-A-3+Di1MUVhXy4w@mail.gmail.com>
Date:	Tue, 17 Jun 2014 09:44:58 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Pannirselvam Kanagaratnam <pannir@...ail.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: Device Tree Binding for Marvell DSA on P1023RDB

On Jun 16, 2014 11:41 PM, "Pannirselvam Kanagaratnam" <pannir@...ail.com> wrote:
>
>
> On 17/06/2014 12:38 AM, Florian Fainelli wrote:
>>
>> 2014-06-16 9:30 GMT-07:00 Pannirselvam Kanagaratnam <pannir@...ail.com>:
>> Distributed Switch Architecture driver version 0.1
>> dsa: probe of dsa.16 failed with error -22
>> This error might not come from dsa_of_probe(), please instrument the
>> code where -EINVAL is returned to see exactly which part of the
>> probing code is failing.
>
>
> The error is coming from:
>
> dev = dev_to_net_device(pd->netdev);
> if (dev == NULL) {
>                 ret = -EINVAL;
>                 goto out;
>         }

Ok, I could not find which Freescale Ethernet driver you are using,
but my guess is that we cannot look up the struct net_device that is
associated with the struct platform_device of your network driver,
most likely because the network driver failed to call
SET_NETDEV_DEV(). Also, if your Ethernet driver is modular, that might
be a problem if it get probed after DSA.

>
> Is my device tree ok?

It is.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html